Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1714: Missing metrics port annotation #1715

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

alexeykaplin
Copy link
Contributor

@alexeykaplin alexeykaplin commented Oct 14, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1714

Checklist:

  • Docs included if any changes are user facing

@aws-kf-ci-bot
Copy link
Contributor

Hi @alexeykaplin. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aws-kf-ci-bot
Copy link
Contributor

@alexeykaplin: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexeykaplin alexeykaplin changed the title fixes #1714: Missing metrics port annotation #1714: Missing metrics port annotation Oct 14, 2021
@deepak-muley
Copy link

/ok-to-test

@deepak-muley
Copy link

/assign @andreyvelich

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 73.696% when pulling c340dea on alexeykaplin:fix-1714 into 195db29 on kubeflow:master.

@johnugeorge
Copy link
Member

johnugeorge commented Oct 22, 2021

@alexeykaplin Thanks for the contribution. Sorry for the delay.

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykaplin, deepak-muley, deepakm-ntnx, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 5a719e9 into kubeflow:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus port missing on a katib-controller pod
9 participants