-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifests: Upgrade cert-manager API from v1alpha2 to v1 #1752
manifests: Upgrade cert-manager API from v1alpha2 to v1 #1752
Conversation
Hi @haoxins. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this update!
I left comment.
@@ -1,4 +1,4 @@ | |||
apiVersion: cert-manager.io/v1alpha2 | |||
apiVersion: cert-manager.io/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it require any additional API changes after switching from v1alpha2
to v1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using cert-manager
v1.3
in the manifests repo.
The cert-manager
deprecated the following cert-manager APIs from v1.4
cert-manager.io/v1alpha2
cert-manager.io/v1alpha3
cert-manager.io/v1beta1
acme.cert-manager.io/v1alpha2
acme.cert-manager.io/v1alpha3
acme.cert-manager.io/v1beta1
https://cert-manager.io/docs/release-notes/release-notes-1.4/
And the latest cert-manager
only supports v1
now.
/ok-to-test |
I also updated the kserve manifests kserve/kserve#1929 |
is this ready to merge? |
Sorry for the late review @haoxins. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, haoxins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.