Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release tags for Trial images #1757

Merged

Conversation

andreyvelich
Copy link
Member

Fixes: #1554.
I added latest tag for Trial images.
For SDK examples, I use release tags, since we are installing specific version of Katib SDK.

Also, I modified update-images script to re-use it in release and e2e tests.
Currently, this script updates all Katib images that we maintain.

Please take a look.

/assign @gaocegege @tenzen-y @anencore94 @johnugeorge

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link

coveralls commented Dec 2, 2021

Coverage Status

Coverage decreased (-0.08%) to 74.138% when pulling 171be75 on andreyvelich:issue-1554-trial-release-tag into 1519724 on kubeflow:master.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm
/hold

@google-oss-prow google-oss-prow bot removed the lgtm label Dec 3, 2021
@andreyvelich andreyvelich changed the title [WIP] Use release tags for Trial images Use release tags for Trial images Dec 3, 2021
@andreyvelich
Copy link
Member Author

This PR should be ready.
/hold for the review

Copy link
Member

@anencore94 anencore94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
just a small question: Is there some special reason to use semantic version in notebook files rather than using latest ?

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, anencore94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

Is there some special reason to use semantic version in notebook files rather than using latest

Since we install the specific version of Katib SDK in our notebooks, it's better to be consistent with the Trial images.

@andreyvelich
Copy link
Member Author

/hold cancel

@andreyvelich
Copy link
Member Author

@ca-scribner @DomFleischmann Any ideas why Charms can fail ?

@tenzen-y tenzen-y mentioned this pull request Dec 6, 2021
1 task
@tenzen-y
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 10, 2021
@google-oss-prow google-oss-prow bot merged commit 7be1f0a into kubeflow:master Dec 10, 2021
@andreyvelich andreyvelich deleted the issue-1554-trial-release-tag branch December 10, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use release tags for the Trial images
6 participants