-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use release tags for Trial images #1757
Use release tags for Trial images #1757
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/lgtm
/hold
f36153f
to
171be75
Compare
This PR should be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
just a small question: Is there some special reason to use semantic version in notebook files rather than using latest
?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, anencore94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since we install the specific version of Katib SDK in our notebooks, it's better to be consistent with the Trial images. |
/hold cancel |
@ca-scribner @DomFleischmann Any ideas why Charms can fail ? |
171be75
to
af2b76b
Compare
/lgtm |
Fixes: #1554.
I added latest tag for Trial images.
For SDK examples, I use release tags, since we are installing specific version of Katib SDK.
Also, I modified
update-images
script to re-use it in release and e2e tests.Currently, this script updates all Katib images that we maintain.
Please take a look.
/assign @gaocegege @tenzen-y @anencore94 @johnugeorge