Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

katib/operators: removes unrecognized keys from metadata.yaml #1759

Merged

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Dec 9, 2021

Charmed Katib CI is failing due to recent changes in juju bundle as it no longer recognizes certain keys in metadata.yaml. This PR should prevent the following:

Error: YAML Error: unknown field `display-name`, expected one of `name`, `summary`, `description`, `maintainers`, `terms`, `subordinate`, `containers`, `resources`, `provides`, `requires`, `peer`, `storage`, `devices`, `extra-bindings`, `series` at line 2 column 1

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 74.264% when pulling c9770d9 on DnPlas:dnplas/fix-charmed-katib-ci into 1519724 on kubeflow:master.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix @DnPlas!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, DnPlas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a2b5dae into kubeflow:master Dec 9, 2021
@DnPlas DnPlas deleted the dnplas/fix-charmed-katib-ci branch May 18, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants