-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus scraping and grafana support to charmed katib-controller operator #1839
Conversation
Hi @jardon. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Revert to defaults for relation names and paths, where appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
These are not working properly. When connecting to grafana, the dashboard shows up but does not populate properly with data. The data source appears wrong
Without this, upgrade-charm does not work.
Update grafana/prometheus implementation for charmed operator of katib
/retest |
I think this just failed because the github runner was particularly slow. Not sure how to get the tests to rerun though |
I rerun the jobs manually. |
fix: bump wait time to avoid flaky test failure
ty! We bumped the timeout on the flaky test too so it shouldn't fail like it did before. This should be good to go now |
@ca-scribner Can you lgtm this PR if it is ready to be merged? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ca-scribner, jardon, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
These changes add support for prometheus scraping and providing a grafana dashboard to the charmed katib-controller operator. With the changes you can do the following to connect the applications and enable scraping:
Checklist: