Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Black to fix linting #1842

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Upgrade Black to fix linting #1842

merged 3 commits into from
Apr 5, 2022

Conversation

jardon
Copy link
Contributor

@jardon jardon commented Mar 31, 2022

What this PR does / why we need it:
Black is broken due to a change in the click dependency and is fixed in version 22.3.0. Here is a link to the related issue

Checklist:

  • Docs included if any changes are user facing

@aws-kf-ci-bot
Copy link
Contributor

Hi @jardon. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Apr 1, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 74.264% when pulling 5f1f3b3 on jardon:fix-linting into 9c88bbc on kubeflow:master.

@johnugeorge
Copy link
Member

Can you fix operator lint issues?

@johnugeorge johnugeorge mentioned this pull request Apr 1, 2022
Merged
@johnugeorge
Copy link
Member

/ok-to-test

@johnugeorge
Copy link
Member

@jardon Can you fix this ?

@johnugeorge
Copy link
Member

Katib CI is broken due to this

@DomFleischmann @knkski @ca-scribner

@johnugeorge johnugeorge mentioned this pull request Apr 4, 2022
Merged
1 task
@ca-scribner
Copy link
Contributor

@johnugeorge yeah I'll sort this one out. Thanks!

@ca-scribner
Copy link
Contributor

@johnugeorge I think that sorts it out, but I'm not sure how to get the tests to run again. ok-to-test is already on there

@ca-scribner
Copy link
Contributor

/retest

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 5, 2022
@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jardon, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 36d0a57 into kubeflow:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anencore94 anencore94 Awaiting requested review from anencore94

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@johnugeorge johnugeorge

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jardon @aws-kf-ci-bot @coveralls @johnugeorge @ca-scribner