-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors when running the test on Apple Silicon M1 #1886
Conversation
We need to merge this PR after merging #1882. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
b60690d
to
03e96d9
Compare
I have fixed an error from shellcheck. |
/lgtm |
@johnugeorge @gaocegege Thanks for your review! |
What this PR does / why we need it:
I fixed the following errors when running the test on Apple Silicon M1.
It seems that this error occurred when
setup-envtest
tried to download the Kubernetes components binary for darwin/arm64 as described in this issue.So I specified CPU architecture when running the
setup-envtest
.It seems that this error occurred since darwin/arm64 is not supported by the
github.com/shirou/gopsutil
v2 as described in this issue.So I upgraded the
github.com/shirou/gopsutil
version to v3.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: