Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when running the test on Apple Silicon M1 #1886

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jun 5, 2022

What this PR does / why we need it:
I fixed the following errors when running the test on Apple Silicon M1.

unable to find a version that was supported for platform darwin/arm64

It seems that this error occurred when setup-envtest tried to download the Kubernetes components binary for darwin/arm64 as described in this issue.
So I specified CPU architecture when running the setup-envtest.

# github.com/shirou/gopsutil/process
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.7+incompatible/process/process_darwin.go:590:34: undefined: KinfoProc
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.7+incompatible/process/process_darwin.go:591:8: undefined: KinfoProc
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.7+incompatible/process/process_darwin.go:604:32: undefined: KinfoProc
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.7+incompatible/process/process_darwin.go:608:62: undefined: KinfoProc

It seems that this error occurred since darwin/arm64 is not supported by the github.com/shirou/gopsutil v2 as described in this issue.
So I upgraded the github.com/shirou/gopsutil version to v3.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y
Copy link
Member Author

tenzen-y commented Jun 5, 2022

We need to merge this PR after merging #1882.
/hold

@coveralls
Copy link

coveralls commented Jun 5, 2022

Coverage Status

Coverage decreased (-0.3%) to 73.948% when pulling 95a5dda on tenzen-y:specify-cpu-arch into 72fff88 on kubeflow:master.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/lgtm

@tenzen-y tenzen-y force-pushed the specify-cpu-arch branch from b60690d to 03e96d9 Compare June 6, 2022 05:46
@tenzen-y
Copy link
Member Author

tenzen-y commented Jun 6, 2022

I have fixed an error from shellcheck.
https://github.com/kubeflow/katib/runs/6750242050?check_suite_focus=true

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 6, 2022
@tenzen-y
Copy link
Member Author

tenzen-y commented Jun 6, 2022

@johnugeorge @gaocegege Thanks for your review!
/hold cancel

@google-oss-prow google-oss-prow bot merged commit e2378c3 into kubeflow:master Jun 6, 2022
@tenzen-y tenzen-y deleted the specify-cpu-arch branch June 6, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants