-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] health check for katib-controller #1934
[feat] health check for katib-controller #1934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! @anencore94
I left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you update this doc?
3d573c5
to
e7b328f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anencore94 Thanks for the updates!
/lgtm
Could you re-run the failed action and re-review if you don't mind? @johnugeorge |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anencore94, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I've referenced the health check way from other components:
So in my opinion, the liveness check with just
ping
is ok, but for readiness check, I'm not sure do we need more detailed way to check it or not.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1930
Checklist: