Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix namespace parameter in tune API #1981

Merged

Conversation

andreyvelich
Copy link
Member

We should send namespace parameter to create_experiment API, so user can set it using tune API.

cc @tenzen-y @johnugeorge @anencore94

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich Thanks fro fixing this!
/lgtm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 73.522% when pulling cf5ca59 on andreyvelich:fix-sdk-tune-namespace into 8cbaf85 on kubeflow:master.

@google-oss-prow google-oss-prow bot merged commit 1a10652 into kubeflow:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants