Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kwa-kfp-component] Introduce KWA's frontend component for kfp links #1991

Merged
merged 1 commit into from
Nov 11, 2022
Merged

[kwa-kfp-component] Introduce KWA's frontend component for kfp links #1991

merged 1 commit into from
Nov 11, 2022

Conversation

elenzio9
Copy link
Contributor

@elenzio9 elenzio9 commented Nov 1, 2022 •
edited
Loading

In this PR:

  • Introduce the kfp-run component as a distinct component.
  • Make the pipeline button a link.

Here's a screenshot:
image

Signed-off-by: Elena Zioga elena@arrikto.com

@coveralls
Copy link

coveralls commented Nov 1, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 73.545% when pulling 0a63d8d on arrikto:feature-elena-kwa-kfp-component into 6b55540 on kubeflow:master.

@johnugeorge
Copy link
Member

Can you rebase?

@elenzio9 elenzio9 force-pushed the feature-elena-kwa-kfp-component branch from e512e46 to 0a63d8d Compare November 1, 2022 14:39
@tenzen-y
Copy link
Member

tenzen-y commented Nov 2, 2022

@kimwnasptd Can you help us with reviewing this PR?

/assign @kimwnasptd

@kimwnasptd
Copy link
Member

kimwnasptd commented Nov 3, 2022 •
edited
Loading

@elenzio9 Before merging this PR I'd suggest to first have a GH action that continuously checks the tests #1977 (comment).

@orfeas-k can you take a stab at it?

@johnugeorge
Copy link
Member

@elenzio9 Can you post a screenshot of the change?

@orfeas-k orfeas-k mentioned this pull request Nov 3, 2022
Merged
@elenzio9
Copy link
Contributor Author

elenzio9 commented Nov 3, 2022

@elenzio9 Can you post a screenshot of the change?

I just updated the PR description with a screenshot, but as you can see it remains the same. We introduced the kfp-run component as a distinct component because we'll need it for an upcoming effort where we'll re-use the common table we have for the Trials list. This way we'll be able to integrate easier with future efforts for sorting, pagination and filtering.

Related issues: #1441, kubeflow/kubeflow#6460, kubeflow/kubeflow#6462

@kimwnasptd
Copy link
Member

@elenzio9 now that we've merged the tests PR with @orfeas-k #1998, can you rebase on top of the latest master and force push?

I'd expect that

  1. Only the tests relevant with the frontend will get triggered
  2. The unit tests will be running

@elenzio9
UI: Introduce kfp-run component
7bc3d04 
* Introduce the kfp-run component as a distinct component.
* Make the pipeline button a link.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 force-pushed the feature-elena-kwa-kfp-component branch from 0a63d8d to 7bc3d04 Compare November 11, 2022 13:49
@kimwnasptd
Copy link
Member

Great to see that the tests pass and that they are just the ones for the frontend!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 11, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0848e03 into kubeflow:master Nov 11, 2022
@kimwnasptd kimwnasptd deleted the feature-elena-kwa-kfp-component branch November 11, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anencore94 anencore94 Awaiting requested review from anencore94

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@kimwnasptd kimwnasptd

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elenzio9 @coveralls @johnugeorge @tenzen-y @kimwnasptd