Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for k8s v1.25 in CI #1997

Merged
merged 6 commits into from
Nov 4, 2022
Merged

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Nov 3, 2022

K8s 1.25 is added to CI and 1.22 is dropped.
Kubernetes dependencies are also updated to v0.25.3

Fixes: #1957

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Nov 3, 2022

Coverage Status

Coverage increased (+0.1%) to 73.533% when pulling af93dea on johnugeorge:k8s1.25 into 68ecb1c on kubeflow:master.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnugeorge Thanks for updating the kubernetes version!

Can you also upgrade the setup-envtest version, K8s version for envtest, prerequires version in Readme, and kind version for example?

katib/Makefile

Line 23 in 68ecb1c

go install sigs.k8s.io/controller-runtime/tools/setup-envtest@c7a98aa706379c4e5c79ea675c7f333192677971 # v0.12.3

ENVTEST_K8S_VERSION ?= 1.24

# Step 1. Create Kind cluster with Kubernetes v1.24.4
kind create cluster --image kindest/node:v1.24.4
echo -e "\nKind cluster has been created\n"

@@ -29,7 +29,7 @@ jobs:
strategy:
fail-fast: false
matrix:
kubernetes-version: ["v1.22.14", "v1.23.11", "1.24.5"]
kubernetes-version: ["v1.23.12", "v1.24.6", "v1.25.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the latest patch versions (1.23.13, 1.24.7, 1.25.3)?

Copy link
Member Author

@johnugeorge johnugeorge Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change setup-envtest to 2c3a6fa2996c026b284c7fe2b055274cd9a556bc # v0.13.0

@tenzen-y
Copy link
Member

tenzen-y commented Nov 3, 2022

ref: #1993

@tenzen-y
Copy link
Member

tenzen-y commented Nov 4, 2022

@johnugeorge
Thanks for updating PR!
Can you also update prerequires version in Readme?

@tenzen-y
Copy link
Member

tenzen-y commented Nov 4, 2022

Thanks!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 4, 2022
@google-oss-prow google-oss-prow bot merged commit 54b020b into kubeflow:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kubernetes v1.25
3 participants