frontend: Make trials table support pagination/sorting/filtering #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenzio9
changed the title
There was a problem hiding this comment.
Thank you for this amazing feature @elenzio9!
/assign @kimwnasptd
* Update the COMMIT file. Signed-off-by: Elena Zioga <elena@arrikto.com>
…1441) * Make trials table support paging, sorting and filtering. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Create unit tests for trials-table component. Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-kwa-trials-table
branch
from
157f53c
to
cbe3c4e
Compare
|
The changes look good! Great to see that we are using the common table component for the Trials table as well /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Make the trials table support pagination/sorting/filtering #1441
Make the KWA's main table support filtering
Related PRs: #2017, kubeflow/kubeflow#6742, kubeflow/kubeflow#6754