Add Trial Labels During Pod Mutation #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andreyvelich
force-pushed
the
add-label-to-trial-pods
branch
from
50a32c9
to
3a704a0
Compare
andreyvelich
force-pushed
the
add-label-to-trial-pods
branch
from
3a704a0
to
3e4a19d
Compare
tenzen-y
reviewed
Dec 2, 2022
There was a problem hiding this comment.
@andreyvelich Thanks for this work! This feature makes helpful users!
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed on the recent AutoML WG meeting, we should add Trial labels to the pod during mutation.
We need it to get Trial logs from the Katib UI backend: #2039.
cc @kimwnasptd @johnugeorge @tenzen-y @d-gol