Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kwa(front): Sort conditions table by timestamp #2067

Closed
wants to merge 1 commit into from
Closed

kwa(front): Sort conditions table by timestamp #2067

wants to merge 1 commit into from

Conversation

orfeas-k
Copy link
Contributor

This is a follow-up PR to this and updates the COMMIT file to checkout to the latest KF commit and have the conditions table sorted by timestamp by default.

andreyvelich
andreyvelich reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @orfeas-k!
/assign @kimwnasptd @elenzio9

This was referenced Dec 23, 2022
Merged
Merged
@tenzen-y
Copy link
Member

Blocked by: #2070

@tenzen-y
Copy link
Member

@orfeas-k Can you rebase since we fixed CI?

@orfeas-k orfeas-k force-pushed the feature-orfeas-kwa-sort-conditions-table branch from 3d30d0b to d9ccbcb Compare January 3, 2023 08:59
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: orfeas-k
Once this PR has been reviewed and has the lgtm label, please ask for approval from kimwnasptd by writing /assign @kimwnasptd in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@orfeas-k
Copy link
Contributor Author

orfeas-k commented Jan 3, 2023

@tenzen-y I just rebased and pushed, happy new year!

@elenzio9
Copy link
Contributor

@orfeas-k thanks for the update! Tested and worked as expected!
cc @kimwnasptd
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 13, 2023
@elenzio9
Copy link
Contributor

@orfeas-k Could you rebase the branch on top of the latest master to fix the conflict in the COMMIT file?

@orfeas-k
kwa(front): Sort conditions table by timestamp
9e9a423 
Update COMMIT file to checkout to latest KF common commit and have
conditions table sorted by timestamp by default.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
@orfeas-k orfeas-k force-pushed the feature-orfeas-kwa-sort-conditions-table branch from d9ccbcb to 9e9a423 Compare January 20, 2023 10:49
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 20, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@orfeas-k
Copy link
Contributor Author

@elenzio9 Just rebased and pushed.

@orfeas-k
Copy link
Contributor Author

I see that a GH action failed although nothing changed in the PR's file in comparison with before the rebase I just did. Is there a chance that this GH action is flaky and we need to rerun it? cc @kimwnasptd

@tenzen-y
Copy link
Member

@orfeas-k Maybe, we can close this PR since we updated the COMMIT file to a newer version in #2090.

WDYT?

@orfeas-k
Copy link
Contributor Author

@tenzen-y Sure, this makes total sense. Thanks for noticing!

@orfeas-k orfeas-k closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@anencore94 anencore94 Awaiting requested review from anencore94

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@kimwnasptd kimwnasptd

@elenzio9 elenzio9

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@orfeas-k @tenzen-y @elenzio9 @andreyvelich @kimwnasptd