Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chocolate Suggestion Service #2071

Conversation

tenzen-y
Copy link
Member

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I removed all coded related Chocolate Suggestion Service.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #2058

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

/hold for the review

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tenzen-y!
@tenzen-y @gaocegege @johnugeorge @anencore94 Do we want to inform users that in 1.7 Grid is supported by Optuna ?

@johnugeorge
Copy link
Member

@andreyvelich Does it really matter as this is transparent to the user?

@andreyvelich
Copy link
Member

@andreyvelich Does it really matter as this is transparent to the user?

No, I think that is useful only for users who might use other algorithms from Chocolate (e.g. QuasiRandom).

@johnugeorge
Copy link
Member

We can add this info in the release note.

@johnugeorge
Copy link
Member

LGTM
/assign @andreyvelich

@andreyvelich
Copy link
Member

/lgtm
@tenzen-y Feel free to unhold it.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 5, 2023
@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 5, 2023

Thanks @tenzen-y! @tenzen-y @gaocegege @johnugeorge @anencore94 Do we want to inform users that in 1.7 Grid is supported by Optuna ?

We can add this info in the release note.

Sounds good.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 5, 2023

@andreyvelich @johnugeorge Thanks for your review!
/hold cancel

@google-oss-prow google-oss-prow bot merged commit 9270274 into kubeflow:master Jan 5, 2023
@tenzen-y tenzen-y deleted the remove-chocolate-suggestion-service branch January 5, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants