-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Chocolate Suggestion Service #2071
Remove Chocolate Suggestion Service #2071
Conversation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tenzen-y!
@tenzen-y @gaocegege @johnugeorge @anencore94 Do we want to inform users that in 1.7 Grid is supported by Optuna ?
@andreyvelich Does it really matter as this is transparent to the user? |
No, I think that is useful only for users who might use other algorithms from Chocolate (e.g. QuasiRandom). |
We can add this info in the release note. |
LGTM |
/lgtm |
Sounds good. |
@andreyvelich @johnugeorge Thanks for your review! |
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
What this PR does / why we need it:
I removed all coded related Chocolate Suggestion Service.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part-of #2058
Checklist: