Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwa(front): Add UI tests with Cypress #2088

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

orfeas-k
Copy link
Contributor

This PR adds UI tests with Cypress for functionalities of the KWA frontend. More specifically, they check that:

  • New Experiment form page loads template without errors.
  • Index page
    • has an "Experiments" title
    • lists experiments without errors
    • renders every experiment name into the table
    • renders properly Status icon for all experiments

Everything implementation-specific (mock API, node version etc) mentioned in the VWA UI tests PR stand for this one too.

Copy link
Contributor

@elenzio9 elenzio9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orfeas-k While the README section instructs the user to use npm run e2e or npm run e2e-ci-all to run the UI tests, the npm scripts in package.json are different. Is this expected?

 - Install Cypress & npm scripts for UI tests
 - Remove Protractor files
 - Add README.md file to include UI tests instructions
 - Modify .gitignore

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Add UI tests with Cypress to check that:
 - New Experiment form page loads template without errors.
 - Index page
    * has an "Experiments" title
    * lists experiments without errors
    * renders every experiment name into the table
    * renders properly Status icon for all experiments

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
@orfeas-k
Copy link
Contributor Author

@elenzio9 Good observation! I fixed this and pushed again.

@elenzio9
Copy link
Contributor

Other than that it looks great! Thank you @orfeas-k!
cc @kimwnasptd
/lgtm

@orfeas-k
Copy link
Contributor Author

The failed job Go Test / Unit Test is flaky as @tenzen-y mentioned here #1979 (comment).

@kubeflow/wg-automl-leads Can you restart the failed GH-Actions Job?

@tenzen-y
Copy link
Member

/assign @kimwnasptd

@kimwnasptd
Copy link
Member

Looks good, thanks for the work @orfeas-k and the review @elenzio9!

/lgtm
/approve

@kimwnasptd
Copy link
Member

@tenzen-y since this PR touches some of the GH Actions we'll also need you to approve the PR to merge

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, orfeas-k, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c5923cb into kubeflow:master Jan 26, 2023
@kimwnasptd kimwnasptd deleted the feature-orfeas-kwa-ui-tests branch January 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants