-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Rework the trial graph using ECharts in KWA #2089
frontend: Rework the trial graph using ECharts in KWA #2089
Conversation
/assign @kimwnasptd |
That's amazing @elenzio9! I really like that user can better view the metrics on a plot. |
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
d1eb1be
to
3041626
Compare
@andreyvelich You're right! I just removed it and pushed again. |
This looks amazing! Went through the code and it LGTM. I also built and tested the image on my cluster and it works as expected. Thank you @elenzio9! cc @kimwnasptd |
Great to see that we've fully moved away from the previous D3 implementation and use ECharts everywhere! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this PR:
d3
referencesClick here for some screenshots of how the new graph will look like.