Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Rework the trial graph using ECharts in KWA #2089

Merged

Conversation

elenzio9
Copy link
Contributor

@elenzio9 elenzio9 commented Jan 17, 2023

In this PR:

  • Rework the trial graph using the ECharts library as we do for the experiments graph
  • Enable actions in the trial graph and specifically:
  • Remove all d3 references
Click here for some screenshots of how the new graph will look like.

image
image
image

@johnugeorge
Copy link
Member

/assign @kimwnasptd

@andreyvelich
Copy link
Member

That's amazing @elenzio9! I really like that user can better view the metrics on a plot.
Do we still need this assets: https://github.com/kubeflow/katib/tree/master/pkg/new-ui/v1beta1/frontend/src/assets/css ?

Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 force-pushed the feature-elena-kwa-rework-trial-graph branch from d1eb1be to 3041626 Compare January 18, 2023 10:30
@elenzio9
Copy link
Contributor Author

Do we still need this assets: https://github.com/kubeflow/katib/tree/master/pkg/new-ui/v1beta1/frontend/src/assets/css ?

@andreyvelich You're right! I just removed it and pushed again.

@orfeas-k
Copy link
Contributor

This looks amazing! Went through the code and it LGTM. I also built and tested the image on my cluster and it works as expected. Thank you @elenzio9!
/lgtm

cc @kimwnasptd

@kimwnasptd
Copy link
Member

Great to see that we've fully moved away from the previous D3 implementation and use ECharts everywhere!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 026d9ed into kubeflow:master Jan 26, 2023
@kimwnasptd kimwnasptd deleted the feature-elena-kwa-rework-trial-graph branch January 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants