Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e with various Python versions to verify Python SDK #2092

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

tenzen-y
Copy link
Member

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

What this PR does / why we need it:
As discussed in #2057 (comment), run e2e with various Python versions to verify Python SDK.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y
Copy link
Member Author

/hold for the review

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenzen-y @johnugeorge Any thoughts how to keep Python versions and this version consistent:

"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
?
Then, we can say that we test our SDK on every version that we suggested.

@johnugeorge
Copy link
Member

I can't think of easy way to use the same versions in sync. (other than some kind of parse)

@tenzen-y
Copy link
Member Author

I don't have any good idea. As @johnugeorge says, we might need to parse setup.py and workflow files.

@andreyvelich
Copy link
Member

@johnugeorge @tenzen-y I see, let's keep the sync for minor version (3.7, 3.8, etc.) manually for now.

@andreyvelich
Copy link
Member

/lgtm
/assign @johnugeorge

@tenzen-y
Copy link
Member Author

I'm thinking of applying the same patch to the training-operator.

@johnugeorge
Copy link
Member

/approve
/hold cancel

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants