[SDK] Use Katib Client without Kube Config #2098
Conversation
google-oss-prow
bot
requested review from
anencore94,
gaocegege and
johnugeorge
| else: | ||
| config.load_incluster_config() | ||
| self.in_cluster = True | ||
| self.in_cluster = False |
There was a problem hiding this comment.
@tenzen-y Currently, we use it when Katib is deployed as part of Kubeflow Central Dashboard: https://github.com/kubeflow/katib/blob/master/sdk/python/v1beta1/kubeflow/katib/api/katib_client.py#L112-L124.
Although, it can generate incorrect links when user relies on load_incluster_config() and doesn't run it from Kubeflow Notebooks.
We will discuss about it in the future.
There was a problem hiding this comment.
I see.
Thanks for clarifying! Could you create an issue to keep tracking this?
There was a problem hiding this comment.
Sure, let's track this.
|
Thanks! |
andreyvelich
force-pushed
the
sdk-no-config
branch
from
b76715d
to
23bfee5
Compare
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Use the same logic as for the SDK Training Client: kubeflow/training-operator#1740.
/assign @gaocegege @johnugeorge @tenzen-y