-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax dependencies restriction for the gRPC libraries #2140
Relax dependencies restriction for the gRPC libraries #2140
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @andreyvelich @johnugeorge cc: @ryandawsonuk |
sdk/python/v1beta1/setup.py
Outdated
"grpcio>=1.41.1", | ||
"protobuf>=3.19.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this @tenzen-y!
Since we don't have proper tests in SDK to verify the GRPC lib functionality yet, can we update the versions in other Katib services as well. For example, tf event collector and other Suggestion services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right.
I will change the versions in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
87f161c
to
1bff1c0
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
1bff1c0
to
3904581
Compare
It seems that we must use the
https://github.com/kubeflow/katib/actions/runs/4577679497/jobs/8083373344?pr=2140#step:4:10112 |
Maybe, we must regenerate codes using a newer protoc in follow-up PRs. |
@tenzen-y @johnugeorge We currently, use |
@andreyvelich I agree. However, I think we can do that in another PR. wdyt? |
@tenzen-y Sure, please can you create an issue to track it ? |
What this PR does / why we need it:
I relaxed the version restrictions on dependencies in the Python SDK.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2139
Checklist: