Fix storelogs #222
Merged
Fix storelogs #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YujiOshima
reviewed
Oct 23, 2018
pkg/db/interface.go
Outdated
| // in worker_metrics. | ||
| rows, err := d.db.Query( | ||
| "SELECT worker_lastlogs.time, name, value FROM worker_lastlogs "+ | ||
| "LEFT JOIN worker_metrics ON (worker_lastlogs.worker_id = worker_metrics.worker_id AND worker_lastlogs.time = worker_metrics.time) "+ |
There was a problem hiding this comment.
Why not using ` to make a multiple line string?
The function has been storing into worker_metrics with duplicates and wrong timestamps for some time. The fix changes the worker_lastlogs DB table definition. DBs must be recreated. Signed-off-by: IWAMOTO Toshihiro <iwamoto@valinux.co.jp>
toshiiw
force-pushed
the
fix-storelogs
branch
from
e4642ce
to
3c8a872
Compare
YujiOshima
reviewed
Oct 23, 2018
| name VARCHAR(255), | ||
| value TEXT, | ||
| is_objective TINYINT, | ||
| FOREIGN KEY (worker_id) REFERENCES workers(id) ON DELETE CASCADE)`) |
There was a problem hiding this comment.
Could you replace " + to ` on other tables?
There was a problem hiding this comment.
My idea was to minimize the size of diff. It might be better to tidy all the things now. Just a sec.
…tting This patch make sure worker_* rows have matching row in the worker table. Also changes multi-line string formatting for readability. Signed-off-by: IWAMOTO Toshihiro <iwamoto@valinux.co.jp>
toshiiw
force-pushed
the
fix-storelogs
branch
from
3c8a872
to
5861ad6
Compare
|
@toshiiw Great, Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures worker logs are stored correctly.
Also tweak DB table definitions for consistency.
This change is