-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Optuna Validation for CMA-ES #2240
Fix Optuna Validation for CMA-ES #2240
Conversation
@andreyvelich: GitHub didn't allow me to assign the following users: shipengcheng1230. Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can we do cherry-pick this commit into the latest release branch?
/lgtm
Actually, I am not sure if we need to do another Release to fix this. WDYT @tenzen-y ? |
I don't think it is valuable to cut a new patch release v0.16.1. However, I think we should make Dockerfiles buildable and the image should work fine on the latest release branch (release-0.16). @andreyvelich WDYT? |
/lgtm |
Great, tests were succeeded. |
@tenzen-y But how user can find out about this fix if we are not going to update the Changelog and cut the new release ? |
@andreyvelich My suggestions aim to keep the latest branch runnable without the costs of a new patch release. So, I wanted to just say that we should keep the latest release branch proper regardless of whether we cut a new patch release. |
Since Optuna recently moved
cmaes
to optional dependencies, our CI is failing: optuna/optuna#4901.I bumped Optuna to 3.3.0 version to unblock it, we can keep specific version of Optuna for now to avoid such errors.
If we need to relax the version, we can discuss the long-term plan on how to identify such errors in advance.
Also, I noticed that we have incorrect validation for
cmaes
in Optuna service.We need to check that Search Space has more than 2 dimensional continues parameters instead of checking Algorithm Settings, similar to Goptuna: https://github.com/kubeflow/katib/blob/master/pkg/suggestion/v1beta1/goptuna/service.go#L188-L196
/assign @tenzen-y @johnugeorge @c-bata @shipengcheng1230