Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only retry an INSERT operation on unique constraint violation #229

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Only retry an INSERT operation on unique constraint violation #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions pkg/db/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,14 @@ func generateRandid() string {
return string(rs1Letters[rand.Intn(len(rs1Letters))]) + fmt.Sprintf("%016x", id)[1:]
}

func isDBDuplicateError(err error) bool {
errmsg := strings.ToLower(err.Error())
if strings.Contains(errmsg, "unique") || strings.Contains(errmsg, "duplicate") {
return true
}
return false
}

func (d *dbConn) GetStudyConfig(id string) (*api.StudyConfig, error) {
row := d.db.QueryRow("SELECT * FROM studies WHERE id = ?", id)

Expand Down Expand Up @@ -240,13 +248,10 @@ func (d *dbConn) CreateStudy(in *api.StudyConfig) (string, error) {
)
if err == nil {
break
} else {
errmsg := strings.ToLower(err.Error())
if strings.Contains(errmsg, "unique") || strings.Contains(errmsg, "duplicate") {
i--
if i > 0 {
continue
}
} else if isDBDuplicateError(err) {
i--
if i > 0 {
continue
}
}
return "", err
Expand Down Expand Up @@ -387,13 +392,10 @@ func (d *dbConn) CreateTrial(trial *api.Trial) error {
if err == nil {
trial.TrialId = trialID
break
} else {
errmsg := strings.ToLower(err.Error())
if strings.Contains(errmsg, "unique") || strings.Contains(errmsg, "duplicate") {
i--
if i > 0 {
continue
}
} else if isDBDuplicateError(err) {
i--
if i > 0 {
continue
}
}
return err
Expand Down Expand Up @@ -728,13 +730,10 @@ func (d *dbConn) CreateWorker(worker *api.Worker) (string, error) {
if err == nil {
worker.WorkerId = workerID
break
} else {
errmsg := strings.ToLower(err.Error())
if strings.Contains(errmsg, "unique") || strings.Contains(errmsg, "duplicate") {
i--
if i > 0 {
continue
}
} else if isDBDuplicateError(err) {
i--
if i > 0 {
continue
}
}
return "", err
Expand Down Expand Up @@ -917,6 +916,8 @@ func (d *dbConn) SetSuggestionParam(algorithm string, studyID string, params []*
paramID, algorithm, studyID, strings.Join(ps, ",\n"))
if err == nil {
break
} else if !isDBDuplicateError(err) {
return "", err
}
}
return paramID, err
Expand Down Expand Up @@ -1025,6 +1026,8 @@ func (d *dbConn) SetEarlyStopParam(algorithm string, studyID string, params []*a
paramID, algorithm, studyID, strings.Join(ps, ",\n"))
if err == nil {
break
} else if !isDBDuplicateError(err) {
return "", err
}
}
return paramID, nil
Expand Down