Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UT of each suggestion algorithm #237

Merged
merged 9 commits into from
Nov 30, 2018
Merged

add UT of each suggestion algorithm #237

merged 9 commits into from
Nov 30, 2018

Conversation

ytetra
Copy link
Contributor

@ytetra ytetra commented Nov 7, 2018 •
edited by jlewi
Loading

add unit test of ranfom algorithm, grid algorithm, and hyperband algorithm

This change is Reviewable

@YujiOshima
Copy link
Contributor

@ytetra Thank you for a great job!
/ok-to-test

@YujiOshima
Copy link
Contributor

Related #42

@ytetra
Copy link
Contributor Author

ytetra commented Nov 7, 2018

/retest

1 similar comment
@YujiOshima
Copy link
Contributor

/retest

YujiOshima
YujiOshima reviewed Nov 20, 2018
View reviewed changes
pkg/suggestion/hyperband_service_test.go Outdated

}

func TestPurseSuggestionParameters(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Parse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,I fix it.

pkg/suggestion/grid_service_test.go
"testing"
)

func TestAllocInt(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add test for genGrids, parseSuggestParam , and setP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Please wait for a while.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GenGrid, parseSuggestParam, and setP test added.

@jlewi
Copy link
Contributor

jlewi commented Nov 26, 2018

@ytetra Thanks for doing this! Any chance you update the PR this week? Would be great to close this out.

@ytetra
Copy link
Contributor Author

ytetra commented Nov 27, 2018

@jlewi ok. I finish this PR in this week.

@YujiOshima
Copy link
Contributor

/lgtm
/approve
@ytetra Thank you!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3f5462d into kubeflow:master Nov 30, 2018
@ytetra ytetra deleted the algo_unittest branch December 21, 2018 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YujiOshima YujiOshima YujiOshima left review comments

@ddysher ddysher Awaiting requested review from ddysher

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

Assignees

@YujiOshima YujiOshima

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ytetra @YujiOshima @jlewi @k8s-ci-robot