Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly set namespace #260

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Fix incorrectly set namespace #260

merged 1 commit into from
Nov 26, 2018

Conversation

lkpdn
Copy link
Contributor

@lkpdn lkpdn commented Nov 26, 2018 •
edited by jlewi
Loading

Commit b6f8e07 ("Update manifests (#246)") has just changed the
namespace as a whole. This new manifest should be updated as well.

Fixes: 67e94c7 ("Set MYSQL_ROOT_PASSWORD via Secret (#253)")
Signed-off-by: Koichiro Den den@valinux.co.jp

This change is Reviewable

Fix incorrectly set namespace
48ae824 
Commit b6f8e07 ("Update manifests (kubeflow#246)") has just changed the
namespace as a whole. This new manifest should be updated as well.

Fixes: 67e94c7 ("Set MYSQL_ROOT_PASSWORD via Secret (kubeflow#253)")
Signed-off-by: Koichiro Den <den@valinux.co.jp>
@k8s-ci-robot
Copy link

Hi @lkpdn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnugeorge
Copy link
Member

/ok-to-test

@YujiOshima
Copy link
Contributor

@lkpdn Thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b7145b3 into kubeflow:master Nov 26, 2018
@lkpdn
Copy link
Contributor Author

lkpdn commented Nov 26, 2018

Thanks for quick review + merge!

@lkpdn lkpdn deleted the fix-incorrect-namespace-in-manifest branch November 26, 2018 10:45
@lkpdn lkpdn mentioned this pull request Nov 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddysher ddysher Awaiting requested review from ddysher

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

Assignees

@YujiOshima YujiOshima

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lkpdn @k8s-ci-robot @johnugeorge @YujiOshima