fix studyJob status suggestionCount mismatch error #290
Conversation
|
/assign @richardsliu |
| @@ -73,7 +73,6 @@ func initializeStudy(instance *katibv1alpha1.StudyJob, ns string) error { | |||
| return err | |||
| } | |||
| instance.Status.SuggestionParameterID = sPID | |||
| instance.Status.SuggestionCount += 1 | |||
There was a problem hiding this comment.
SuggestionCount should record how many times the studyJob had called suggestion, and this value should += 1 every time after calling suggestion.
Here (initialize studyJob instance and no suggestion called before) instance.Status.SuggestionCount should be 0 (0 by default).
There was a problem hiding this comment.
@YujiOshima Is this the intended behavior? Should we update the API documentation instead?
There was a problem hiding this comment.
For now, SuggestionParam["SuggestionCount"] in db change path is [0, 2, 3, ..., requestcount+1].
after this patch its path is [0,1,2,...,requestcount]
There was a problem hiding this comment.
@hougangliu Thanks.
SuggestionParam["SuggestionCount"] in db change path is [0, 2, 3, ..., requestcount+1].
This is not intended behavior, we may need to fix. I'm reviewing and testing this PR.
|
/lgtm |
|
@hougangliu Thank you! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #289
This change is