Database APIs for NAS #328

Akado2009 · 2019-01-17T10:08:31Z

This change is

ss

Akado2009 · 2019-01-17T10:12:00Z

This PR introduces a distinct set of API functions to save/get NAS jobs into the mysql databases. For now it creates a separate table, but after new update we're gonna use studies table, just increase the number of columns in that one. This one should be merged after: #327.

YujiOshima · 2019-01-21T04:29:16Z

pkg/db/db_init.go

@@ -15,9 +23,13 @@ func (d *dbConn) DBInit() {
 		optimization_goal DOUBLE,
 		parameter_configs TEXT,
 		tags TEXT,
+		trials TEXT,


Please add a timestamp fields to Trial table instead of adding this to Study.

YujiOshima · 2019-01-21T04:32:53Z

pkg/db/interface.go

@@ -341,6 +343,201 @@ func (d *dbConn) DeleteStudy(id string) error {
 	return err
 }

+func (d *dbConn) CreateNAS(in *api.StudyConfig) (string, error) {


The level is different between CreateNAS and CreateStudy. Please change them to an equal level e.g. CreateNASStudy, CreateHPStudy.

YujiOshima · 2019-01-21T04:35:18Z

pkg/db/interface.go

+	var configs string
+
+	i := 3
+	for true {


It looks the same process with CreateStudy. Please merge them and split only different process.

andreyvelich · 2019-02-13T19:46:13Z

/retest

andreyvelich · 2019-02-14T01:17:47Z

/retest

andreyvelich

https://github.com/kubeflow/katib/pull/328/files#diff-33e387bcd92f8daa961d6a060454aadeR23

andreyvelich · 2019-02-14T02:17:11Z

pkg/db/interface_test.go

@@ -119,7 +119,7 @@ func TestGetStudyConfig(t *testing.T) {
 	mock.ExpectQuery("SELECT").WillReturnRows(
 		sqlmock.NewRows(studyColumns).AddRow(
 			"abc", "test", "admin", 1, 0.99, "{}", "", "", "", "test"))
-	study, err := dbInterface.GetStudyConfig(id)
+	study, err := dbInterface.GetStudy(id)
 	if err != nil {


You should also change this things:

Add 2 values in StudyColumns:

katib/pkg/db/interface_test.go

Line 23 in 297324d

var studyColumns = []string{

Add value "time" in trialColumns:

katib/pkg/db/interface_test.go

Line 27 in 297324d

var trialColumns = []string{

Add 2 empty values:

katib/pkg/db/interface_test.go

Line 119 in 297324d

mock.ExpectQuery("SELECT").WillReturnRows(

Add 1 empty value:

katib/pkg/db/interface_test.go

Line 216 in 297324d

sqlmock.NewRows(trialColumns).AddRow(

Add 2 Values empty values:

katib/pkg/db/interface_test.go

Line 367 in 297324d

studyID, "test", "admin", 1, 0.99, "{}", "", "", "foo,\nbar", "test"))

Add 1 empty value:

katib/pkg/db/interface_test.go

Line 233 in 297324d

rows.AddRow(id, studyID, "", "obj_val", "")

andreyvelich · 2019-02-14T02:50:23Z

/retest

k8s-ci-robot · 2019-02-16T00:59:26Z

New changes are detected. LGTM label has been removed.

k8s-ci-robot · 2019-02-16T00:59:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hougangliu

If they are not already assigned, you can assign the PR to them by writing /assign @hougangliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot · 2019-02-16T00:59:34Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

andreyvelich · 2019-02-16T01:28:20Z

/cla yes

jlewi · 2019-02-16T20:28:39Z

The CLA check is failing because you have multiple commits with different authors. Please rebase and squash the commits so that all your commits are coming from a single author.

andreyvelich · 2019-02-18T21:43:48Z

/retest

andreyvelich · 2019-02-19T01:09:43Z

@YujiOshima @hougangliu @johnugeorge
We finally fixed all presubmit tests.
Can you check, please, all the difference that we made in that PR?

YujiOshima · 2019-02-19T01:19:16Z

pkg/db/interface.go

-			&dummyJobID,
-		)
+		var temporaryId string
+		err := d.db.QueryRow("SELECT id FROM studies WHERE job_id = ?", in.JobId).Scan(&temporaryId)


Please check sql.ErrNoRows error instead nil.

YujiOshima · 2019-02-19T01:21:56Z

pkg/db/interface.go

-			&dummyJobID,
-		)
+		var temporaryId string
+		err := d.db.QueryRow("SELECT id FROM studies WHERE job_id = ?", in.JobId).Scan(&temporaryId)


Please check sql.ErrNoRows instead of nil check.

YujiOshima · 2019-02-19T01:23:34Z

cmd/manager/main_test.go

 )

 func TestCreateStudy(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()
 	mockDB := mockdb.NewMockVizierDBInterface(ctrl)
-	mockModelStore := mockmodelstore.NewMockModelStore(ctrl)
+	// Don't need test for Model Store. Right now Katib doesn't use ModelDB.


Removing mockModelStore test is reasonable but it is not related to this PR. Could you split it to another PR?

Should I split changing version of the cluster (https://github.com/kubeflow/katib/pull/328/files#diff-3d8f11bfc35c15745c970724619c57c3L36) in another PR, as well?
Also, should I delete tests for mockModelStore or just comment it?

changing version of the cluster

Yes, please split it.

mockModelStore

You can delete it.

YujiOshima · 2019-02-19T01:30:17Z

pkg/db/interface.go

 		err := rows.Scan(&trial.TrialId,
 			&trial.StudyId,
 			&parameters,
 			&trial.ObjectiveValue,
 			&tags,
+			&timeStamp,


In other grpc APIs, RFC3339Nano format is used, not MySQL format.
Please convert timeStamp to the format when returning api.Trial.

Right now, in the Trial API we don't have time field.
https://github.com/kubeflow/katib/blob/master/pkg/api/api.proto#L363
We store it in database, but can't get with grpc APIs.
Should we extend this API with time and add parsing in the separate PR?

I see.
Yes, please add a timestamp field to grpc API and write doc about the format.

Ok, I will do it in a separate PR.

k8s-ci-robot · 2019-02-20T02:06:32Z

@Akado2009: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
kubeflow-katib-presubmit	`58ad9fc`	link	`/test kubeflow-katib-presubmit`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Akado2009 added 2 commits January 16, 2019 18:00

Merge pull request #1 from kubeflow/master

ee8ee09

ss

small fix

80d6158

k8s-ci-robot requested review from ddysher and jose5918 January 17, 2019 10:08

k8s-ci-robot added the size/M label Jan 17, 2019

Akado2009 mentioned this pull request Jan 17, 2019

Extend Katib API for NAS jobs #327

Merged

Akado2009 changed the title ~~Database APIs for NAS~~ WIP: Database APIs for NAS Jan 17, 2019

k8s-ci-robot added the do-not-merge/work-in-progress label Jan 17, 2019

INIT AND APIS ADDED

74f431d

k8s-ci-robot added size/L and removed size/M labels Jan 17, 2019

Akado2009 added 6 commits January 17, 2019 16:01

Manager fixed

6289424

asdasd

0850c33

Update interface.go

c010b0e

Update main.go

049a90e

Update main.go

7b14c28

ALMOST FINJAL FIX

3c52221

YujiOshima reviewed Jan 21, 2019

View reviewed changes

Akado2009 added 11 commits January 22, 2019 11:21

HP/NAS Separations, TIMESTAMP added to Trials

f90580c

db test fixed

10238cf

small fix

f0d92b7

Code refactored + several new functions introduced

4151390

Update interface.go

de311dd

Update interface.go

6431ed1

Update main.go

a92a9d6

Update interface.go

243e3ce

Update main.go

adb9d1d

FINAL FIX

0766c4e

EXTRA LOGS DELETED

224f0a7

andreyvelich reviewed Feb 14, 2019

View reviewed changes

Fix unittest in db

58ad9fc

k8s-ci-robot removed the lgtm label Feb 16, 2019

k8s-ci-robot added size/XXL size/L size/XL and removed size/L size/XXL size/XL labels Feb 16, 2019

YujiOshima reviewed Feb 19, 2019

View reviewed changes

k8s-ci-robot added size/XXL size/L and removed size/L size/XXL labels Feb 20, 2019

Akado2009 closed this Feb 20, 2019

Akado2009 mentioned this pull request Feb 20, 2019

Database APIs for NAS updated #394

Merged

andreyvelich mentioned this pull request Feb 20, 2019

Add time to Trial API #397

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Database APIs for NAS #328

Database APIs for NAS #328

Akado2009 commented Jan 17, 2019 •

edited by jlewi

Loading

Akado2009 commented Jan 17, 2019 •

edited

Loading

YujiOshima Jan 21, 2019

Akado2009 Jan 22, 2019

YujiOshima Jan 21, 2019

Akado2009 Jan 22, 2019

YujiOshima Jan 21, 2019

andreyvelich commented Feb 13, 2019

andreyvelich commented Feb 14, 2019

andreyvelich left a comment

andreyvelich Feb 14, 2019

andreyvelich commented Feb 14, 2019

k8s-ci-robot commented Feb 16, 2019

k8s-ci-robot commented Feb 16, 2019

googlebot commented Feb 16, 2019

andreyvelich commented Feb 16, 2019

jlewi commented Feb 16, 2019

andreyvelich commented Feb 18, 2019

andreyvelich commented Feb 19, 2019

YujiOshima Feb 19, 2019

andreyvelich Feb 19, 2019

YujiOshima Feb 19, 2019

YujiOshima Feb 19, 2019

andreyvelich Feb 19, 2019

YujiOshima Feb 19, 2019

YujiOshima Feb 19, 2019

andreyvelich Feb 19, 2019

YujiOshima Feb 19, 2019

andreyvelich Feb 19, 2019

k8s-ci-robot commented Feb 20, 2019

Database APIs for NAS #328

Database APIs for NAS #328

Conversation

Akado2009 commented Jan 17, 2019 • edited by jlewi Loading

Akado2009 commented Jan 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreyvelich commented Feb 13, 2019

andreyvelich commented Feb 14, 2019

andreyvelich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreyvelich commented Feb 14, 2019

k8s-ci-robot commented Feb 16, 2019

k8s-ci-robot commented Feb 16, 2019

googlebot commented Feb 16, 2019

andreyvelich commented Feb 16, 2019

jlewi commented Feb 16, 2019

andreyvelich commented Feb 18, 2019

andreyvelich commented Feb 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 20, 2019

Akado2009 commented Jan 17, 2019 •

edited by jlewi

Loading

Akado2009 commented Jan 17, 2019 •

edited

Loading