Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix presubmits #363

Merged
merged 4 commits into from
Feb 8, 2019
Merged

Fix presubmits #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
694fdc2
Fix typo
richardsliu Jan 17, 2019
b1ec4d4
Merge remote-tracking branch 'upstream/master'
richardsliu Feb 7, 2019
51a202d
Fix gcloud builds submit command
richardsliu Feb 7, 2019
ce9dd3b
Use printf() instead of print()
richardsliu Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/ui/ui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ func (k *KatibUIHandler) UpdateWorkerTemplate(w http.ResponseWriter, r *http.Req
}
err := k.studyjobClient.UpdateWorkerTemplates(wt)
if err != nil {
log.Print("fail to UpdateWorkerTemplate %v", err)
log.Printf("fail to UpdateWorkerTemplate %v", err)
}
}

Expand Down Expand Up @@ -400,7 +400,7 @@ func (k *KatibUIHandler) UpdateMetricsCollectorTemplate(w http.ResponseWriter, r
}
err := k.studyjobClient.UpdateMetricsCollectorTemplates(mt)
if err != nil {
log.Print("fail to UpdateMetricsCollectorTemplate %v", err)
log.Printf("fail to UpdateMetricsCollectorTemplate %v", err)
}
}

Expand Down
2 changes: 1 addition & 1 deletion test/scripts/build-earlystopping-median.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ cp -r vendor ${GO_DIR}/vendor
cd ${GO_DIR}

cp cmd/earlystopping/medianstopping/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/earlystopping-medianstopping:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/earlystopping-medianstopping:${VERSION} --project=${PROJECT}
2 changes: 1 addition & 1 deletion test/scripts/build-manager-rest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ cp -r vendor ${GO_DIR}/vendor

cd ${GO_DIR}
cp cmd/manager-rest/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/vizier-core-rest:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/vizier-core-rest:${VERSION} --project=${PROJECT}
2 changes: 1 addition & 1 deletion test/scripts/build-manager.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ cp -r vendor ${GO_DIR}/vendor

cd ${GO_DIR}
cp cmd/manager/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/vizier-core:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/vizier-core:${VERSION} --project=${PROJECT}
6 changes: 3 additions & 3 deletions test/scripts/build-studyjobctr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ cp -r vendor ${GO_DIR}/vendor

cd ${GO_DIR}
cp cmd/studyjobcontroller/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/studyjob-controller:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/studyjob-controller:${VERSION} --project=${PROJECT}

cd ${GO_DIR}
cp cmd/metricscollector/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/metrics-collector:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/metrics-collector:${VERSION} --project=${PROJECT}

cd ${GO_DIR}
cp cmd/tfevent-metricscollector/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/tfevent-metrics-collector:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/tfevent-metrics-collector:${VERSION} --project=${PROJECT}
2 changes: 1 addition & 1 deletion test/scripts/build-suggestion-bo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ cp -r vendor ${GO_DIR}/vendor
cd ${GO_DIR}

cp cmd/suggestion/bayesianoptimization/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-bayesianoptimization:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-bayesianoptimization:${VERSION} --project=${PROJECT}
2 changes: 1 addition & 1 deletion test/scripts/build-suggestion-grid.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ cp -r vendor ${GO_DIR}/vendor
cd ${GO_DIR}

cp cmd/suggestion/grid/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-grid:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-grid:${VERSION} --project=${PROJECT}
2 changes: 1 addition & 1 deletion test/scripts/build-suggestion-hyperband.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ cp -r vendor ${GO_DIR}/vendor
cd ${GO_DIR}

cp cmd/suggestion/hyperband/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-hyperband:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-hyperband:${VERSION} --project=${PROJECT}
2 changes: 1 addition & 1 deletion test/scripts/build-suggestion-random.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ cp -r vendor ${GO_DIR}/vendor
cd ${GO_DIR}

cp cmd/suggestion/random/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-random:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-random:${VERSION} --project=${PROJECT}
2 changes: 1 addition & 1 deletion test/scripts/build-ui.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ cp -r vendor ${GO_DIR}/vendor

cd ${GO_DIR}
cp cmd/ui/Dockerfile .
gcloud container builds submit . --tag=${REGISTRY}/${REPO_NAME}/katib-ui:${VERSION} --project=${PROJECT}
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/katib-ui:${VERSION} --project=${PROJECT}