-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include go dependencies in developer-guide.md #369
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Hi @alexandraj777. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
SigOpt should now have a signed CLA in place! Per the instructions, my work email address should be on the google group associated with the agreement |
/assign @hougangliu |
/assign @richardsliu |
/ok-to-test |
/lgtm |
@hougangliu thank you for approving! This is my first time committing to this project, what are the next steps I should take here? I know signing a CLA was a blocker, and it looks like the Google CLA system finally shows my corporate CLA on the dashboard. |
@alexandraj777 Can you reply to the PR with "I signed it!"? |
I signed it! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like Google protobufs might also be a dependency?
CLAs look good, thanks! |
@richardsliu I figured it out! The email address on my commit was my personal email address, but the email address on my CLA was my work email address. This has been fixed, and force pushed to this branch. Mind re-approving for me? |
/lgtm |
/retest |
@alexandraj777 Looks like we're running into quota problems. I'll let you know once it gets resolved. |
/retest |
Easier for new-to-go developers to get up and running.
Looks like Google protobufs might also be a dependency?
This change is