Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include go dependencies in developer-guide.md #369

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Include go dependencies in developer-guide.md #369

merged 1 commit into from
Feb 13, 2019

Conversation

alexandraj777
Copy link
Contributor

@alexandraj777 alexandraj777 commented Feb 11, 2019

Easier for new-to-go developers to get up and running.

Looks like Google protobufs might also be a dependency?


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@k8s-ci-robot
Copy link

Hi @alexandraj777. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexandraj777
Copy link
Contributor Author

SigOpt should now have a signed CLA in place! Per the instructions, my work email address should be on the google group associated with the agreement

@alexandraj777
Copy link
Contributor Author

/assign @hougangliu

@alexandraj777
Copy link
Contributor Author

/assign @richardsliu

@richardsliu
Copy link
Contributor

/ok-to-test

@hougangliu
Copy link
Member

/lgtm

@alexandraj777
Copy link
Contributor Author

@hougangliu thank you for approving! This is my first time committing to this project, what are the next steps I should take here? I know signing a CLA was a blocker, and it looks like the Google CLA system finally shows my corporate CLA on the dashboard.

@richardsliu
Copy link
Contributor

@alexandraj777 Can you reply to the PR with "I signed it!"?

@alexandraj777
Copy link
Contributor Author

I signed it!

@richardsliu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Looks like Google protobufs might also be a dependency?
@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 12, 2019
@googlebot
Copy link

CLAs look good, thanks!

@alexandraj777
Copy link
Contributor Author

@richardsliu I figured it out! The email address on my commit was my personal email address, but the email address on my CLA was my work email address. This has been fixed, and force pushed to this branch. Mind re-approving for me?

@johnugeorge
Copy link
Member

/lgtm

@richardsliu
Copy link
Contributor

/retest

@richardsliu
Copy link
Contributor

@alexandraj777 Looks like we're running into quota problems. I'll let you know once it gets resolved.

@richardsliu
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 41a5a2e into kubeflow:master Feb 13, 2019
@alexandraj777 alexandraj777 deleted the patch-1 branch February 14, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants