Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove katibcli #436

Merged
merged 5 commits into from
Mar 20, 2019
Merged

Remove katibcli #436

merged 5 commits into from
Mar 20, 2019

Conversation

jdplatt
Copy link
Contributor

@jdplatt jdplatt commented Mar 16, 2019

Addresses #273. I'm pretty sure this is everything related to the CLI. Did I miss anything, or worse delete something we still need?


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @jdplatt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YujiOshima
Copy link
Contributor

/ok-to-test

@jdplatt
Copy link
Contributor Author

jdplatt commented Mar 18, 2019

/retest

@jdplatt
Copy link
Contributor Author

jdplatt commented Mar 18, 2019

Ok I fixed the failing test. There was some code to copy the go dependencies to the mounted volume in the build-cli.sh test script that we still needed. I copied it over to the unit-test.sh script.

@jdplatt
Copy link
Contributor Author

jdplatt commented Mar 20, 2019

/assign @richardsliu

@YujiOshima
Copy link
Contributor

/lgtm

@richardsliu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e260258 into kubeflow:master Mar 20, 2019
@jdplatt jdplatt mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants