Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve frontend #60

Merged
merged 2 commits into from
Apr 20, 2018
Merged

improve frontend #60

merged 2 commits into from
Apr 20, 2018

Conversation

YujiOshima
Copy link
Contributor

Fix bug and little improve for UI
bugs

  • Categorical parameter didn't be select range by drag at the parallel coordinate graph.
  • Fail to link TensorBoard.

improves

  • Get an overview of the models selected by the parallel coordinate graph.
  • Improve visualization of the parallel coordinate graph.

ss

Signed-off-by: YujiOshima yuji.oshima0x3fd@gmail.com

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@gaocegege
Copy link
Member

I think I have no ability to review frontend code now, thus let us go ahead and invite some people has frontend background to be reviewers.

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/hold

Does it WIP or done?

@YujiOshima
Copy link
Contributor Author

YujiOshima commented Apr 20, 2018

@gaocegege Thanks. I agree we need frontend reviewer.
This is done. We can merge it.

@YujiOshima
Copy link
Contributor Author

/hold cancel

@gaocegege gaocegege merged commit dd6c87e into kubeflow:master Apr 20, 2018
@gaocegege
Copy link
Member

BTW, could we have a new demo (gif or video) in README to show the new UI?

@YujiOshima YujiOshima deleted the frontupdate branch April 24, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants