Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip creating trials if add count is zero #617

Merged
merged 1 commit into from
May 31, 2019
Merged

Skip creating trials if add count is zero #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions pkg/controller/v1alpha2/experiment/experiment_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,13 +331,15 @@ func (r *ReconcileExperiment) ReconcileTrials(instance *experimentsv1alpha2.Expe
addCount = 0
}

//create "addCount" number of trials
logger.Info("CreateTrials", "addCount", addCount)
if err := r.createTrials(instance, addCount); err != nil {
logger.Error(err, "Create trials error")
return err
//skip if no trials need to be created
if addCount > 0 {
//create "addCount" number of trials
logger.Info("CreateTrials", "addCount", addCount)
if err := r.createTrials(instance, addCount); err != nil {
logger.Error(err, "Create trials error")
return err
}
}

}

return nil
Expand Down