-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stdout of worker container show nothing #819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Will tee command exist in all user images?/ |
tee is a Linux command, I think it should be in all Linux distributions. |
@johnugeorge based on https://en.wikipedia.org/wiki/List_of_Unix_commands, |
@hougangliu Thats the only concern that i had. Looks good to me otherwise |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-katib-presubmit |
/retest |
/test kubeflow-katib-presubmit |
Fixes: #810
This change is