Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple metric logs in one line #925

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Support multiple metric logs in one line #925

merged 2 commits into from
Nov 22, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Nov 21, 2019

for now, in one line, only $metricsName=$value (without blank) can be parsed.
By this PR, blank can be tolerant before and after "="; Also in the same line, multiple metrics couple can be parsed


This change is Reviewable

@hougangliu
Copy link
Member Author

/cc @gaocegege @johnugeorge

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some unit test cases for the change?

@hougangliu
Copy link
Member Author

Can we add some unit test cases for the change?

Sure, I can update it soon

@gaocegege
Copy link
Member

Thanks. I cannot confirm the effect of the code by code review, thus prefer having such test cases to illustrate it.

@hougangliu
Copy link
Member Author

Thanks. I cannot confirm the effect of the code by code review, thus prefer having such test cases to illustrate it.

I had updated image in examples/v1alpha3/file-metricscollector-example.yaml to test the change

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

1 similar comment
@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

@johnugeorge
Copy link
Member

Can we document this now? There will be more similar things in the future

@hougangliu
Copy link
Member Author

Can we document this now? There will be more similar things in the future

I will implement filter filed in coming days and then will document how filter should be defined and what default filter is.

@gaocegege
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 40f55b4 into kubeflow:master Nov 22, 2019
@hougangliu hougangliu deleted the defautl-file-mc-filter branch November 22, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants