-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple metric logs in one line #925
Support multiple metric logs in one line #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some unit test cases for the change?
Sure, I can update it soon |
Thanks. I cannot confirm the effect of the code by code review, thus prefer having such test cases to illustrate it. |
I had updated |
/test kubeflow-katib-presubmit |
1 similar comment
/test kubeflow-katib-presubmit |
Can we document this now? There will be more similar things in the future |
I will implement |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
for now, in one line, only $metricsName=$value (without blank) can be parsed.
By this PR, blank can be tolerant before and after "="; Also in the same line, multiple metrics couple can be parsed
This change is