-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deployment api version #937
Conversation
Hi @yeya24. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@yeya24 Thanks for your contribution. You have created lots of PRs, I think you could request to join the org to let bot trigger CI for your PR automatically. Ref https://www.kubeflow.org/docs/about/contributing/#joining-the-kubeflow-github-org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
Thanks, I will try to open a PR for it. |
/retest |
1 similar comment
/retest |
The e2e test only failed in |
Yeah it seems that when the OS executes syscall /retest |
/retest |
1 similar comment
/retest |
/retest Our test infra is not very stable |
/retest |
@yeya24 Can you rebase? |
Signed-off-by: yeya24 <yb532204897@gmail.com>
@johnugeorge CI passed |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yeya24 yb532204897@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Since extensions/v1beta1 is deprecated since k8s 1.16, so migrating to apps/v1
Special notes for your reviewer:
Release note:
This change is