Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deployment api version #937

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 28, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Since extensions/v1beta1 is deprecated since k8s 1.16, so migrating to apps/v1

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@k8s-ci-robot
Copy link

Hi @yeya24. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnugeorge
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

@yeya24 Thanks for your contribution.

You have created lots of PRs, I think you could request to join the org to let bot trigger CI for your PR automatically. Ref https://www.kubeflow.org/docs/about/contributing/#joining-the-kubeflow-github-org

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yeya24
Copy link
Contributor Author

yeya24 commented Nov 28, 2019

/retest

@yeya24
Copy link
Contributor Author

yeya24 commented Nov 28, 2019

@yeya24 Thanks for your contribution.

You have created lots of PRs, I think you could request to join the org to let bot trigger CI for your PR automatically. Ref https://www.kubeflow.org/docs/about/contributing/#joining-the-kubeflow-github-org

Thanks, I will try to open a PR for it.

@johnugeorge
Copy link
Member

/retest

1 similar comment
@yeya24
Copy link
Contributor Author

yeya24 commented Nov 28, 2019

/retest

@yeya24
Copy link
Contributor Author

yeya24 commented Nov 28, 2019

@gaocegege
Copy link
Member

Yeah it seems that when the OS executes syscall read, error is returned. I think it is not caused by the code. Maybe network is broken.

/retest

@yeya24
Copy link
Contributor Author

yeya24 commented Nov 30, 2019

/retest

1 similar comment
@yeya24
Copy link
Contributor Author

yeya24 commented Dec 2, 2019

/retest

@gaocegege
Copy link
Member

/retest

Our test infra is not very stable

@johnugeorge
Copy link
Member

/retest

@johnugeorge
Copy link
Member

@yeya24 Can you rebase?

Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Dec 4, 2019

@johnugeorge CI passed

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d31c7b6 into kubeflow:master Dec 4, 2019
@yeya24 yeya24 deleted the update-yaml branch December 4, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants