Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to tekton 0.16 for next release #304

Closed
Tomcli opened this issue Sep 11, 2020 · 5 comments · Fixed by #321
Closed

update to tekton 0.16 for next release #304

Tomcli opened this issue Sep 11, 2020 · 5 comments · Fixed by #321
Assignees

Comments

@Tomcli
Copy link
Member

Tomcli commented Sep 11, 2020

/kind feature

Description:
Tekton 0.16 introduced several features that can unblock some of our older issues

  • more context variables such as pipeline uid (unblock Map Argo variables to Tekton varaibles. #78)
  • TaskSpec metadata, useful for distinguish task generated by kfp vs tfx
  • variable substitution works on configmap and secrets
  • WhenExpressions (new beta api for conditional)

Deprecation note:

  • conditional v1alpha1 is deprecated
  • PipelineRun.Spec.ServiceAccountNames is being deprecated in favor of PipelineRun.Spec.TaskRunSpec[].ServiceAccountName

Additional information:
[Miscellaneous information that will assist in solving the issue.]

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

1 similar comment
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@Tomcli
Copy link
Member Author

Tomcli commented Sep 11, 2020

/assign

@Tomcli
Copy link
Member Author

Tomcli commented Sep 16, 2020

This will be targeted for the next major kfp-tekton release (1.x)

@Tomcli
Copy link
Member Author

Tomcli commented Sep 18, 2020

As I try to update to Tekton 0.16 along with the tekton go client, I discovered we might lose few backward compatibility on tekton 0.14.3 since there are some taskspec changes.

So I suggest we should create a new branch for the tekton 0.16 work first. Once Openshift pipeline supports tekton 0.16 on Openshift, then we can merge the new Tekton 0.16 changes such as the client, deployment, beta condition, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants