-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature branch for moving to Tekton 0.16 #321
Conversation
/hold |
I have a few comments for the conditions. Also in |
Co-authored-by: Andrew Butler <Andrew.Butler@ibm.com>
Openshift pipeline 0.16 is available in open source, need to check which IKS openshift is supporting this version. |
@ckadner do you have any comment on this PR? If not we can merge it to master since this PR has been rebased multiple times. |
I think this looks okay. But I see changes from other merged PRs in your PR. Did you try to rebase your PR instead of merging those changes into you PR |
At some point there were too many conflicts to rebase on each commit, so I ended up with merging it and solve all the conflicts in a single batch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if there's no more objection i will unhold this PR tomorrow morning. |
/unhold |
Which issue is resolved by this Pull Request:
Resolves #304
These features will break backward compatibility, need to wait for Openshift pipeline to support Tekton 0.16 before merging.
related tasks:
after
on condition node #310 when adding beta whenExpression support - UI PR feat(ui) Update UI to account for the When expression #328Description of your changes:
This is an experimental feature branch for some tekton 0.16 features. We will only merge these features when OKD openshift pipeline supports Tekton 0.16+
Environment tested:
python --version
): 3.7tkn version
): 0.16.3kubectl version
): 1.17/etc/os-release
):