Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): fix typo tekton -> openshift #1290

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix(doc): fix typo tekton -> openshift #1290

merged 1 commit into from
Jul 18, 2023

Conversation

gregsheremeta
Copy link
Contributor

Description of your changes:
fix typo (tekton -> openshift) in "Installing kfp-tekton on OpenShift Pipelines" section

Environment tested:
n/a

  • Python Version (use python --version): n/a
  • Tekton Version (use tkn version): n/a
  • Kubernetes Version (use kubectl version): n/a
  • OS (e.g. from /etc/os-release): n/a

Checklist:

@google-cla
Copy link

google-cla bot commented Jul 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow google-oss-prow bot requested review from fenglixa and yhwang July 18, 2023 15:23
Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the fix

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhwang
Copy link
Member

yhwang commented Jul 18, 2023

@gregsheremeta can you follow the link here: https://cla.developers.google.com/
to finish the CLA sign-up? you can see details from the failed job: cla/google.

@gregsheremeta
Copy link
Contributor Author

can you follow the link here: https://cla.developers.google.com/
to finish the CLA sign-up?

✔️

@google-oss-prow google-oss-prow bot merged commit 7afbf94 into kubeflow:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants