Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): update new image config via env variables #1336

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Aug 29, 2023

Which issue is resolved by this Pull Request:
Resolves #1335

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Aug 29, 2023

cc @diegolovison, changing the base_step code for all the input and output artifact step probably requires to refactor the code into python class. Can this solution work for you?

In V2 we no longer use step injection as we will migrate all the artifacts/results logic to pull from mlmd directly.

@diegolovison
Copy link

Ok

@diegolovison
Copy link

Could we do the same for condition_image_name?
In this case, we will have a pattern

@Tomcli
Copy link
Member Author

Tomcli commented Aug 31, 2023

/assign @yhwang

@Tomcli
Copy link
Member Author

Tomcli commented Aug 31, 2023

Could we do the same for condition_image_name? In this case, we will have a pattern

Sure. Added in the latest commit.

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 31, 2023
@google-oss-prow google-oss-prow bot merged commit 0fe70da into kubeflow:master Aug 31, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Tomcli added a commit that referenced this pull request Sep 1, 2023
* update new image config via env variables

* add env var for condition task image

* update readme
Tomcli added a commit that referenced this pull request Sep 1, 2023
* update new image config via env variables

* add env var for condition task image

* update readme
Tomcli added a commit that referenced this pull request Sep 1, 2023
* update new image config via env variables

* add env var for condition task image

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TektonPipelineConf::set_bash_image_name is not working
3 participants