-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): update new image config via env variables #1336
Conversation
cc @diegolovison, changing the base_step code for all the input and output artifact step probably requires to refactor the code into python class. Can this solution work for you? In V2 we no longer use step injection as we will migrate all the artifacts/results logic to pull from mlmd directly. |
Ok |
Could we do the same for |
/assign @yhwang |
Sure. Added in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli, yhwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update new image config via env variables * add env var for condition task image * update readme
* update new image config via env variables * add env var for condition task image * update readme
* update new image config via env variables * add env var for condition task image * update readme
Which issue is resolved by this Pull Request:
Resolves #1335
Description of your changes:
Environment tested:
python --version
):tkn version
):kubectl version
):/etc/os-release
):Checklist: