feat(backend): Add CA injection to step-copy-artifacts step. Fixes #1394. #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HumairAK
added a commit
to HumairAK/data-science-pipelines-tekton
that referenced
this pull request
Oct 27, 2023
…beflow#1394. (kubeflow#1395) Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
HumairAK
added a commit
to HumairAK/data-science-pipelines-tekton
that referenced
this pull request
Nov 8, 2023
…beflow#1394. (kubeflow#1395) Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
HumairAK
added a commit
to HumairAK/data-science-pipelines-tekton
that referenced
this pull request
Jan 2, 2024
…beflow#1394. (kubeflow#1395) Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #1394
Description of your changes:
This PR adds the option to pull in a trusted bundle that gets mounted to the step-copy artifact steps added by the api server when generating the tekton template. It assumes default location of /etc/ssl/certs.
Environment tested:
python --version): Python 3.11, tested with kfp sdk 1.8tkn version): 0.50kubectl version): OC stable-4.13 / k8s 1.26Checklist: