Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any Sequencer implements #399

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

jinchihe
Copy link
Member

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

There is a requirement: When any one of the Job1, job2 or job3 complete successfully, Job4 will be started. Order doesn’t matter, but we don’t want to wait for all the job status.

image

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

  • The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

    PR titles examples:

    • fix(frontend): fixes empty page. Fixes #1234
      Use fix to indicate that this PR fixes a bug.
    • feat(backend): configurable service account. Fixes #1234, fixes #1235
      Use feat to indicate that this PR adds a new feature.
    • chore: set up changelog generation tools
      Use chore to indicate that this PR makes some changes that users don't need to know.
    • test: fix CI failure. Part of #1234
      Use part of to indicate that a PR is working on an issue, but shouldn't close the issue when merged.
  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

@jinchihe jinchihe changed the title WIP: Any Sequencer implements Any Sequencer implements Dec 31, 2020
@jinchihe
Copy link
Member Author

/assign @fenglixa

@fenglixa
Copy link
Member

fenglixa commented Dec 31, 2020

@jinchihe
Some Lint issues in your code.

import kfp
^
sdk/python/tests/compiler/testdata/any_sequencer_sample.py:2:1: F401 'kfp.components' imported but unused
from kfp import components
^
1     E902 IndentationError: unindent does not match any outer indentation level
2     F401 'kfp' imported but unused
Makefile:78: recipe for target 'lint' failed
make: *** [lint] Error 1

You can run make lint make check_license make unit_test to see detail issues before commit code

@fenglixa
Copy link
Member

/cc @Tomcli

@jinchihe jinchihe force-pushed the any_condition branch 8 times, most recently from 34d1a89 to 1cee5a3 Compare January 4, 2021 06:41
@jinchihe
Copy link
Member Author

jinchihe commented Jan 4, 2021

@fenglixa @Tomcli The CI test passed, ready for another look. Thanks.

@drewbutlerbb4
Copy link
Member

Thanks @jinchihe!

This will require a UI update because the UI doesn't account for the anyConditions dependencies in the DAG. I will submit a PR to cover that after this PR is merged.

@fenglixa
Copy link
Member

fenglixa commented Jan 5, 2021

This will require a UI update because the UI doesn't account for the anyConditions dependencies in the DAG. I will submit a PR to cover that after this PR is merged.

Here is the UI PR #401. Thanks @drewbutlerbb4

@jinchihe
Copy link
Member Author

jinchihe commented Jan 5, 2021

@Tomcli @fenglixa The image related code committed, thanks.

@k8s-ci-robot
Copy link

@jinchihe: GitHub didn't allow me to request PR reviews from the following users: vincent-pli.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Tomcli @fenglixa The image related code committed, thanks.
/cc @vincent-pli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image="registry.access.redhat.com/ubi8/ubi-minimal",
command=["/bin/bash", "-c"],
arguments=["sleep 30"]
).apply(after_any([task1, task2, task3]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: Is there a limit for how many tasks the Any Sequencer can handle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No limitation for task numbers. Thanks.

@jinchihe
Copy link
Member Author

jinchihe commented Jan 6, 2021

@fenglixa any more comments? if not, would you please approve the ticket? Thanks.

@fenglixa
Copy link
Member

fenglixa commented Jan 6, 2021

/Approve Thanks @jinchihe

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fenglixa, jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fb76513 into kubeflow:master Jan 6, 2021
@jinchihe jinchihe deleted the any_condition branch January 6, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants