-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any Sequencer implements #399
Conversation
1b1d948
to
7150415
Compare
/assign @fenglixa |
@jinchihe
You can run |
/cc @Tomcli |
34d1a89
to
1cee5a3
Compare
Thanks @jinchihe! This will require a UI update because the UI doesn't account for the |
Here is the UI PR #401. Thanks @drewbutlerbb4 |
1cee5a3
to
4ea94ec
Compare
4ea94ec
to
36d8600
Compare
36d8600
to
bbccca8
Compare
@jinchihe: GitHub didn't allow me to request PR reviews from the following users: vincent-pli. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
image="registry.access.redhat.com/ubi8/ubi-minimal", | ||
command=["/bin/bash", "-c"], | ||
arguments=["sleep 30"] | ||
).apply(after_any([task1, task2, task3])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: Is there a limit for how many tasks the Any Sequencer
can handle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No limitation for task numbers. Thanks.
@fenglixa any more comments? if not, would you please approve the ticket? Thanks. |
/Approve Thanks @jinchihe |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fenglixa, jinchihe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
There is a requirement: When any one of the Job1, job2 or job3 complete successfully, Job4 will be started. Order doesn’t matter, but we don’t want to wait for all the job status.
Environment tested:
python --version
):tkn version
):kubectl version
):/etc/os-release
):Checklist:
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
PR titles examples:
fix(frontend): fixes empty page. Fixes #1234
Use
fix
to indicate that this PR fixes a bug.feat(backend): configurable service account. Fixes #1234, fixes #1235
Use
feat
to indicate that this PR adds a new feature.chore: set up changelog generation tools
Use
chore
to indicate that this PR makes some changes that users don't need to know.test: fix CI failure. Part of #1234
Use
part of
to indicate that a PR is working on an issue, but shouldn't close the issue when merged.Do you want this pull request (PR) cherry-picked into the current release branch?
If yes, use one of the following options:
cherrypick-approved
label to this PR. The release manager adds this PR to the release branch in a batch update.