-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KFP 1.3.0 Rebase #423
KFP 1.3.0 Rebase #423
Conversation
Resolves kubeflow#410
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/assign @Tomcli @drewbutlerbb4 Please review/revise the following files which had/have merge conflicts. The
|
FYI here is the PR to flx the backend conflicts In this release, kfp moved away from kfam for auth, so we will need the upcoming kubeflow central control plane that uses the new authorization api for multi-user support. |
1dd8b05
to
42ff5fc
Compare
42ff5fc
to
5116197
Compare
Thanks @Tomcli and @drewbutlerbb4 -- I merged your PRs and re-committed them using the @kfp-tekton-bot user |
I fixed the remaining files that still had references to KFP @Tomcli @drewbutlerbb4 @animeshsingh -- I think this PR is ready to merge now but feel free to give it another look. |
from code wise it looks good to me I will leave it for the weekend in case someone found some issue or see something missing in the documents. |
@ckadner can you rebase this PR? |
@Tomcli -- the merge conflicts are resolved. All checks passing again. |
thanks @ckadner |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfp-tekton-bot, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue is resolved by this Pull Request:
Resolves #410
Description of your changes:
Merging the changes from
kubeflow/pipelines
1.0.4..1.3.0
intokfp-tekton
:Process followed:
Environment tested: -- NOT TESTED
python --version
):tkn version
):kubectl version
):/etc/os-release
):/cc @Tomcli @drewbutlerbb4
/assign @Tomcli @drewbutlerbb4
Please review/revise the following files which had/have merge conflicts. The
*.rej
files contain the chunks that Git (and I) could not resolve. Create a PR with the resolved changes on the kfp-tekton-bot fork and remove the*.rej
files for each resolved file.