-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ui) Update any-sequencer dependency parsing #564
(ui) Update any-sequencer dependency parsing #564
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drewbutlerbb4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @Tomcli |
thanks @drewbutlerbb4, the static graph is good. However, when you try to run this any-sequencer example, the dynamic graph has error until task1 is completed. |
|
Thanks @Tomcli should be fixed now. |
thanks @drewbutlerbb4 |
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Parsing dependencies' for any-sequencers used to be based on metadata annotations. Those metadata annotations have been removed and now dependencies can be parsed from arguments in the taskSpec. This PR addresses this and collects the dependencies from the arguments in the taskSpec.
This PR also allows conditional dependencies to be linked as well.
Environment tested:
python --version
):tkn version
):kubectl version
):/etc/os-release
):Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.