Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ui) Update any-sequencer dependency parsing #564

Merged
merged 4 commits into from
Apr 23, 2021
Merged

(ui) Update any-sequencer dependency parsing #564

merged 4 commits into from
Apr 23, 2021

Conversation

drewbutlerbb4
Copy link
Member

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Parsing dependencies' for any-sequencers used to be based on metadata annotations. Those metadata annotations have been removed and now dependencies can be parsed from arguments in the taskSpec. This PR addresses this and collects the dependencies from the arguments in the taskSpec.

This PR also allows conditional dependencies to be linked as well.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drewbutlerbb4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@drewbutlerbb4
Copy link
Member Author

/cc @Tomcli

@google-oss-robot google-oss-robot requested a review from Tomcli April 22, 2021 20:00
@Tomcli
Copy link
Member

Tomcli commented Apr 22, 2021

thanks @drewbutlerbb4, the static graph is good. However, when you try to run this any-sequencer example, the dynamic graph has error until task1 is completed.
https://github.com/kubeflow/kfp-tekton/blob/master/sdk/python/tests/compiler/testdata/any_sequencer.yaml

@Tomcli
Copy link
Member

Tomcli commented Apr 22, 2021

Utils.tsx:32 Error loading run: 59784800-def0-4d46-a399-7701008d583e TypeError: Cannot read property 'status' of undefined
    at WorkflowParser.ts:162
    at Array.forEach (<anonymous>)
    at WorkflowParser.ts:146
    at Function.value (WorkflowParser.ts:108)
    at n.<anonymous> (RunDetails.tsx:744)
    at u (runtime.js:63)
    at Generator._invoke (runtime.js:293)
    at Generator.next (runtime.js:118)
    at r (asyncToGenerator.js:3)
    at s (asyncToGenerator.js:25)

@drewbutlerbb4
Copy link
Member Author

Thanks @Tomcli should be fixed now.

@Tomcli
Copy link
Member

Tomcli commented Apr 23, 2021

thanks @drewbutlerbb4
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants