Migrate volume and loop unit tests to component.yaml and verify with v2 #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @yhwang |
yhwang
reviewed
Aug 10, 2021
yhwang
reviewed
Aug 10, 2021
yhwang
reviewed
Aug 10, 2021
yhwang
reviewed
Aug 10, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli, yhwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Related #670
Description of your changes:
Migrate volume and loop unit tests (alphabetical order from 'v' to the end) to use the new component.yaml that also works with v2. The loop dsl currently only works on single parallel loop for IR, but not for nested loop such as parallel loop inside another parallel loop.
The volumeSnapshotOp is no longer relevant because it was producing the volumeSnapshot alpha API which only can work with Kubernetes 1.17 or below. In the latest version (KFP 1.7.0+) we need to use Kubernetes 1.18 or above in order to run Argo and Tekton CRDs.
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.