remove ContainerOp from test cases - part 3 #693
Conversation
yhwang
force-pushed
the
update-test-cases-3
branch
from
486c18b to
4a8c3aa
Compare
| taskSpec: | ||
| steps: | ||
| - name: main | ||
| args: | ||
| - sleep $(inputs.params.sleep_ms); wget localhost:5678 -O $(results.downloaded-resultoutput.path) | ||
| - | | ||
| sleep None; wget localhost:5678 -O $0 |
There was a problem hiding this comment.
it should be sleep $(inputs.params.sleep_ms);. Do you think valuable replacement for image works in component.yaml?
There was a problem hiding this comment.
I guess it doesn't work. then we need to fix the compiler error. let me revert this and put a comment on issue 670
| - -c | ||
| args: | ||
| - | | ||
| import random; import sys; \ |
There was a problem hiding this comment.
do you think we need a new line here? when compiling it, the newline makes the spacing look very bad.
There was a problem hiding this comment.
sure, merge it with next line
| @@ -74,7 +85,7 @@ spec: | |||
| steps: | |||
| - name: main | |||
| args: | |||
| - echo "$0" | |||
| - echo | |||
There was a problem hiding this comment.
quick question, does this command still work without "$0"?
There was a problem hiding this comment.
yes, for the old one, it uses parameter substitution. the new one just two arguments. both produce the same output
eliminate the usage of ContainerOp in testcases and update the testcase accordingly, including filenames starting with `o` to `u` Signed-off-by: Yihong Wang <yh.wang@ibm.com>
yhwang
force-pushed
the
update-test-cases-3
branch
from
4a8c3aa to
84b6c0e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli, yhwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eliminate the usage of ContainerOp in testcases and
update the testcase accordingly, including filenames starting
with
otourelated to #670
Signed-off-by: Yihong Wang yh.wang@ibm.com