feat(sdk): Update SDK to support custom task timeout on Tekton 0.27 #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScrapCodes
changed the title
ScrapCodes
changed the title
ScrapCodes
force-pushed
the
update_sdk_timeout
branch
from
7a6d726 to
2d4e0c6
Compare
|
@ScrapCodes you probably need to rebase this PR in order to run the pipelinerun CLI with Tekton 0.27.0 that has the timeout spec. |
ScrapCodes
force-pushed
the
update_sdk_timeout
branch
from
2d4e0c6 to
3f2aa58
Compare
|
thanks @ScrapCodes |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScrapCodes, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ScrapCodes
added a commit
to ScrapCodes/kfp-tekton
that referenced
this pull request
Oct 18, 2021
Some of the recent PRs. kubeflow#750 kubeflow#709 kubeflow#706 kubeflow#633 kubeflow#636 kubeflow#638 kubeflow#646
1 task
google-oss-robot
pushed a commit
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #704
Description of your changes:
Added a case for timeout to be added when it is configured for custom tasks.
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.