Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter notebook image should pin TF version #375

Closed
ankushagarwal opened this issue Mar 7, 2018 · 4 comments
Closed

Jupyter notebook image should pin TF version #375

ankushagarwal opened this issue Mar 7, 2018 · 4 comments
Assignees
Labels
area/jupyter Issues related to Jupyter priority/p1

Comments

@ankushagarwal
Copy link
Contributor

The latest image for jupyter notebook uses tensorflow 1.5-dev version and the TFServing image uses tensorflow 1.4 release.

I ran into an issue where I trained a model using the jupyter notebook, but had compatibility issues while serving that model with TFServing.

We should try to maintain the same tensorflow versions in the various kubeflow images.

@jlewi
Copy link
Contributor

jlewi commented Mar 7, 2018

Our notebooks are currently using the nightly build of TF.
https://github.com/kubeflow/kubeflow/blob/master/components/tensorflow-notebook-image/Dockerfile.cpu#L162

We should probably pin TF to a specific version.

/cc @ojarjur

@jlewi jlewi added area/jupyter Issues related to Jupyter priority/p1 labels Mar 7, 2018
@jlewi jlewi changed the title Different tensorflow versions installed in jupyter notebook image and TFServing image Jupyter notebook image should pin TF version Mar 17, 2018
@jlewi
Copy link
Contributor

jlewi commented Mar 17, 2018

We should pin the version of TF in our notebook images.
We should also consider including the TF version in the image name so that we could potentially build images for different versions of TF.

@aronchick
Copy link
Contributor

aronchick commented Mar 17, 2018 via email

@jlewi
Copy link
Contributor

jlewi commented Mar 17, 2018

Agree. For notebook images we can build different notebook images for different TF versions.

Thanks to @ojarjur's changes to the Dockerfile, its already parameterized by the TF version. And thanks to work by @pdmack we can have a drop down box in the Jupyter UI from which users can select the appropriate image to use. So we could have images for different TF versions.

@ankushagarwal ankushagarwal self-assigned this Mar 20, 2018
k8s-ci-robot pushed a commit that referenced this issue Mar 21, 2018
…471)

* Update tensorflow-notebook-image workflow to pin tf version

* Build 1.4.1, 1.5.1, 1.6.0 versions for gpu and cpu
* Update ksonnet version
* Update bazel version

Fixes #375

* Use tf-version in image name instead of tag name

* Use tornado 4.5.3

* Update notebook image path
* Use cudnn 6 for tf1.4
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
* ingress is now networking.k8s.io/v1beta1 this was introduced in
  in 1.8 so there shouldn't be any blocker to upgrading our ingresses now
  https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

  * Most of the ingresses had already been updated

* Deployments are now apps/v1 not extensions/v1beta1

* Delete gcp/basic-auth-ingress rather than updating it.

* Delete kfdef/generic/istio rather than update it

  * It doesn't look like this has been modified since it was copied over
    from the kubeflow/kubeflow repo in 2019. ISTIO configs should be in /istio

* Add a test for deprecated Kubernetes resources fixes kubeflow#375

Regenerate tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jupyter Issues related to Jupyter priority/p1
Projects
None yet
Development

No branches or pull requests

3 participants