Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It didn't return [dead loop] when Python 3 is being used. #760

Closed
gangliao opened this issue May 4, 2018 · 0 comments · Fixed by #759
Closed

It didn't return [dead loop] when Python 3 is being used. #760

gangliao opened this issue May 4, 2018 · 0 comments · Fixed by #759

Comments

@gangliao
Copy link
Contributor

gangliao commented May 4, 2018

kubeflow/tf-controller-examples/tf-cnn/launcher.py

Lines 40 to 49 in fa9f138

for line in iter(process.stdout.readline, ''):
process.stdout.flush()
logging.info(line.strip())
sys.stderr.flush()
sys.stdout.flush()
process.stdout.flush()
if process.stderr:
process.stderr.flush()
for line in iter(process.stdout.readline, ''):

It didn't return [dead loop] when Python 3 is being used.

Bytes literals are always prefixed with 'b' or 'B'; they produce an instance of the bytes type instead of the str type. They may only contain ASCII characters; bytes with a numeric value of 128 or greater must be expressed with escapes.

INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
INFO|2018-05-04T12:34:33|launcher.py|22| b''
@gangliao gangliao mentioned this issue May 4, 2018
Merged
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
@johnugeorge @k8s-ci-robot
Refactor DB interface (kubeflow#760)
27893d3 
* Refactor DB interface

* Fix tests

* Address review comments

* Address review comments

* Address review comments

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bytes literals in Python3
1 participant
@gangliao