Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the instruction for setting up cluster to run test #152

Merged
merged 7 commits into from
Jan 27, 2018
Merged

Fix the instruction for setting up cluster to run test #152

merged 7 commits into from
Jan 27, 2018

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Jan 26, 2018 •
edited
Loading

  1. Fix some text format in README
  2. checkin the vendor for test-infra app.
  3. set service_type for jupyterHubLoadBalancer in nfs-jupyter.jsonnet

@k8s-ci-robot
Copy link
Contributor

Hi @lluunn. Thanks for your PR.

I'm waiting for a kubernetes or google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi
Copy link
Contributor

jlewi commented Jan 27, 2018

/ok-to-test

jlewi
jlewi reviewed Jan 27, 2018
View reviewed changes
testing/test-infra/app.yaml Outdated
@@ -1,12 +1,6 @@
apiVersion: 0.0.1
kind: ksonnet.io/app
libraries:
core:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this and check in vendor. We want to check in vendor so that the code in the repo is sufficient. Please update PR description accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jlewi jlewi merged commit 15ffefc into kubeflow:master Jan 27, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
@YujiOshima @k8s-ci-robot
refactor studyjob CRD controller (kubeflow#152)
8f85e81 
* refactor studyjob CRD controller

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix type

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix test

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* update mocks

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* update deploy and build script

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* Avoid duplication of suggestion request

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* add RawTemplate for WorkerSpec

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
@james-jwu @k8s-ci-robot
Added cspavlou to kubeflow members. (kubeflow#152)
7679250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lluunn @k8s-ci-robot @jlewi