Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag and update v0.3.0 release for chainer-operator #1552

Merged

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Sep 18, 2018

  • updated releasing/image_tags.yaml for tagging v0.3.0 on gcr.io/kubeflow-images-public/chainer-operator:e63dee1
  • updated default chainer-operator image in chainer-operator prototype with gcr.io/kubeflow-images-public/chainer-operator:v0.3.0
  • delete chainer-operator from releaser because chainer-operator docker image is now built on postsubmit job in prow on chainer-operator repo (Publishing docker image in prow (in postsubmit) chainer-operator#26)

ref: kubeflow/chainer-operator#25


This change is Reviewable

@everpeace everpeace changed the title WIP: update chainer-operator image to v0.3.0 image update chainer-operator image to v0.3.0 image Sep 18, 2018
@everpeace
Copy link
Contributor Author

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Sep 18, 2018

I don't think we should submit this until the new image is built and tagged.
How is the new image going to be built and tagged?
Do we need to wait for the releaser to create a new image and then tag it with the 0.3 tag?

@everpeace
Copy link
Contributor Author

everpeace commented Sep 18, 2018

@jlewi sorry for rush. Would you mind giving me some instruction because I'm not familiar with kubeflow release process?? Thanks in advance 🙇

If I could correctly understand how other operator images will be released/tagged and how default images in prototypes will be bumped, I think I can see what my next step is.

@abhi-g
Copy link
Member

abhi-g commented Sep 18, 2018

@everpeace Please see if this helps: https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md

@jlewi
Copy link
Contributor

jlewi commented Sep 18, 2018

I think in a different PR you submitted a change to automatically build a chainer image as part of our nightly builds.

If that's working at some point that should publish a Docker image for chainer. The tag won't be "0.3.0". So your options at that point would be to add someone with appropriate GCR permissions to manually add the tag to that image; or else just go with whatever tag that image used (a datastamp and git hash)

@everpeace
Copy link
Contributor Author

everpeace commented Sep 19, 2018

Thank you @abhi-g and @jlewi for information and advise 🙇

or else just go with whatever tag that image used (a datastamp and git hash)

I would like to go with this plan. Where can I find nightly build (releaser) job log/status??
Once new official chainer image was built, I will update the prototype's default image with it.

@jlewi
Copy link
Contributor

jlewi commented Sep 19, 2018

You can check http://gcr.io/kubeflow-images-public/chainer to see the images that are currently built.

It looks like the release for chainer release workflow isn't running successfully because it can't find the build_image.sh script that the release workflow is added. Did you create a build_image.sh file as described here
https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md#create-release-workflow

I suggest we move the conversation into slack #release for faster coordination.

Note the cron job to run the release workflows is also broken and I'm working on fixing that #1563

@everpeace
Copy link
Contributor Author

Did you create a build_image.sh file as described here

Oh, I forgot adding the script. I will.

I suggest we move the conversation into slack #release for faster coordination.

sure. I will.

Note the cron job to run the release workflows is also broken and I'm working on fixing that

Thank you so much!

@everpeace everpeace changed the title update chainer-operator image to v0.3.0 image WIP: update chainer-operator image to kubeflow-public image Sep 19, 2018
@jlewi
Copy link
Contributor

jlewi commented Sep 21, 2018

Please ping the PR when the image exists and this is ready to be committed.

@everpeace everpeace changed the title WIP: update chainer-operator image to kubeflow-public image update chainer-operator image to kubeflow-public image Sep 26, 2018
@everpeace everpeace force-pushed the update-chainer-job-default-image branch from 9277acc to 5c17039 Compare September 26, 2018 12:30
@everpeace

This comment has been minimized.

@everpeace everpeace force-pushed the update-chainer-job-default-image branch 2 times, most recently from c604284 to 7b67ee3 Compare September 26, 2018 15:54
@everpeace everpeace changed the title update chainer-operator image to kubeflow-public image Tag and update v0.3.0 release for chainer-operator Sep 26, 2018
@everpeace
Copy link
Contributor Author

@jlewi Finally, I think this pr is now ready.

Could you do me a favor? I updated releasing/image_tags.yaml for tagging chainer-operator:v0.3.0. Because I don't have permission, could you execute run_apply_image_tags.sh ??

@jlewi
Copy link
Contributor

jlewi commented Sep 26, 2018

I applied the image tag. Looks like you need to resolve some merge conflicts though.

now chainer-operator docker image is built in prow on chainer-operator repo.
@everpeace everpeace force-pushed the update-chainer-job-default-image branch from 7b67ee3 to 2b00b9b Compare September 26, 2018 23:59
@jlewi
Copy link
Contributor

jlewi commented Sep 27, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 89893bc into kubeflow:master Sep 27, 2018
richardsliu pushed a commit that referenced this pull request Sep 27, 2018
* tag and update chainer-operator image to gcr.io/kubeflow-images-public/chainer-operator:v0.3.0

* delete chainer-operator from releaser

now chainer-operator docker image is built in prow on chainer-operator repo.
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* tag and update chainer-operator image to gcr.io/kubeflow-images-public/chainer-operator:v0.3.0

* delete chainer-operator from releaser

now chainer-operator docker image is built in prow on chainer-operator repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants