-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag and update v0.3.0 release for chainer-operator #1552
Tag and update v0.3.0 release for chainer-operator #1552
Conversation
/assign @jlewi |
I don't think we should submit this until the new image is built and tagged. |
@jlewi sorry for rush. Would you mind giving me some instruction because I'm not familiar with kubeflow release process?? Thanks in advance 🙇 If I could correctly understand how other operator images will be released/tagged and how default images in prototypes will be bumped, I think I can see what my next step is. |
@everpeace Please see if this helps: https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md |
I think in a different PR you submitted a change to automatically build a chainer image as part of our nightly builds. If that's working at some point that should publish a Docker image for chainer. The tag won't be "0.3.0". So your options at that point would be to add someone with appropriate GCR permissions to manually add the tag to that image; or else just go with whatever tag that image used (a datastamp and git hash) |
Thank you @abhi-g and @jlewi for information and advise 🙇
I would like to go with this plan. Where can I find nightly build (releaser) job log/status?? |
You can check http://gcr.io/kubeflow-images-public/chainer to see the images that are currently built. It looks like the release for chainer release workflow isn't running successfully because it can't find the build_image.sh script that the release workflow is added. Did you create a build_image.sh file as described here I suggest we move the conversation into slack #release for faster coordination. Note the cron job to run the release workflows is also broken and I'm working on fixing that #1563 |
Oh, I forgot adding the script. I will.
sure. I will.
Thank you so much! |
Please ping the PR when the image exists and this is ready to be committed. |
9277acc
to
5c17039
Compare
This comment has been minimized.
This comment has been minimized.
c604284
to
7b67ee3
Compare
@jlewi Finally, I think this pr is now ready. Could you do me a favor? I updated |
I applied the image tag. Looks like you need to resolve some merge conflicts though. |
…c/chainer-operator:v0.3.0
now chainer-operator docker image is built in prow on chainer-operator repo.
7b67ee3
to
2b00b9b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* tag and update chainer-operator image to gcr.io/kubeflow-images-public/chainer-operator:v0.3.0 * delete chainer-operator from releaser now chainer-operator docker image is built in prow on chainer-operator repo.
* tag and update chainer-operator image to gcr.io/kubeflow-images-public/chainer-operator:v0.3.0 * delete chainer-operator from releaser now chainer-operator docker image is built in prow on chainer-operator repo.
releasing/image_tags.yaml
for taggingv0.3.0
ongcr.io/kubeflow-images-public/chainer-operator:e63dee1
chainer-operator
prototype withgcr.io/kubeflow-images-public/chainer-operator:v0.3.0
ref: kubeflow/chainer-operator#25
This change is